Fix race conditions in test ConsoleLineTracker#2739
Merged
Conversation
Contributor
Tests in org.eclipse.ant.tests.ui which rely on ConsoleLineTracker fail infrequently in I-builds. This is due to: 1. Relying on a boolean flag for more than two states. The flag indicates whether the last console is closed or not. An initialized console is marked as closed, which can confuse tests waiting on the closed console state. 2. Synchronizing on a transient object. When a console is initialized, the object used for synchronization is replaced. Tests may wait until timeout, due to notifyAll() calls on a different object. This change introduces a state enum and a single lock object, to avoid the race conditions. See: eclipse-platform#2621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in
org.eclipse.ant.tests.uiwhich rely onConsoleLineTrackerfail infrequently in I-builds. This is due to:The flag indicates whether the last console is closed or not. An initialized console is marked as closed, which can confuse tests waiting on the closed console state.
When a console is initialized, the object used for synchronization is replaced. Tests may wait until timeout, due to
notifyAll()calls on a different object.This change introduces a state
enumand a single lock object, to avoid the race conditions.See: #2621